Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maps #793

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Maps #793

merged 2 commits into from
Jan 5, 2024

Conversation

alan-wu
Copy link
Contributor

@alan-wu alan-wu commented Jan 5, 2024

Description

Update map viewer to work with latest s3 bucket change.
Whole body scaffold and context cards should load correctly now.

This pull request also resolves an issue with maps are not loaded correctly.

Type of change

Delete those that don't apply.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I have ran this locally, cypress tests run successfully locally. This can be tested here - https://alan-wu-sparc-app.herokuapp.com/maps?type=wholebody

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

Copy link

cypress bot commented Jan 5, 2024

2 failed tests on run #41 ↗︎

2 48 1 0 Flakiness 0

Details:

Fix an issue with maps page not loading the correct map.
Project: SPARC Portal E2E testing Commit: 4b99fa1da4
Status: Failed Duration: 07:06 💡
Started: Jan 5, 2024 5:38 AM Ended: Jan 5, 2024 5:45 AM
Failed  test/cypress/e2e/userstories.cy.js • 2 failed tests

View Output Video

Test Artifacts
User stories > Should find segmentation in the gallery > Access dataset 1 Screenshots Video
User stories > Should find segmentation in the gallery > Access dataset 2 Screenshots Video

Review all test suite changes for PR #793 ↗︎

@alan-wu alan-wu requested a review from egauzens January 5, 2024 05:46
@alan-wu
Copy link
Contributor Author

alan-wu commented Jan 5, 2024

2 failed tests on run #41 ↗︎

2 48 1 0 Flakiness 0

Details:
Fix an issue with maps page not loading the correct map.
Project: SPARC Portal E2E testing Commit: 4b99fa1da4
Status: Failed Duration: 07:06 💡
Started: Jan 5, 2024 5:38 AM Ended: Jan 5, 2024 5:45 AM
Failed test/cypress/e2e/userstories.cy.js • 2 failed tests

Review all test suite changes for PR #793 ↗︎

This update has fixed the issue with the maps page loading failure and the other failures are not related to this update. Looks like the top result with the word segmentation does not contain any segmentation available for viewing.

@egauzens egauzens merged commit 400cf5c into nih-sparc:master Jan 5, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants