Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added action icons for viewers #797

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

egauzens
Copy link
Contributor

Description

Added viewer action icons in the files table for the remaining viewers as requested in: https://www.wrike.com/open.htm?id=1279141781

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Locally

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

Copy link

cypress bot commented Feb 21, 2024

4 failed tests on run #47 ↗︎

4 43 4 0 Flakiness 0

Details:

Added action icons for viewers
Project: SPARC Portal E2E testing Commit: 163d4a96b9
Status: Failed Duration: 09:03 💡
Started: Feb 21, 2024 3:22 PM Ended: Feb 21, 2024 3:31 PM
Failed  test/cypress/e2e/homepage.cy.js • 4 failed tests

View Output Video

Test Artifacts
Homepage > Projects and datasets Screenshots Video
Homepage > Homepage news Screenshots Video
Homepage > Stay connected Screenshots Video
Homepage > Footer Screenshots Video

Review all test suite changes for PR #797 ↗︎

@egauzens
Copy link
Contributor Author

4 failed tests on run #47 ↗︎

4 43 4 0 Flakiness 0
Details:

Added action icons for viewers
Project: SPARC Portal E2E testing Commit: 163d4a96b9
Status: Failed Duration: 09:03 💡
Started: Feb 21, 2024 3:22 PM Ended: Feb 21, 2024 3:31 PM
Failed  test/cypress/e2e/homepage.cy.js • 4 failed tests

Review all test suite changes for PR #797 ↗︎

None of the failing tests have to do with these changes

@egauzens egauzens merged commit 7a30473 into master Feb 21, 2024
0 of 2 checks passed
@egauzens egauzens deleted the add-action-icons-for-remaining-viewers branch February 21, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants