-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zobrist hashing #45
zobrist hashing #45
Conversation
@wspeirs Thanks, this looks good so far. There are a few issues with chess variants. I believe it does not handle explosions in Maybe you can make the variants implement a supporting trait |
@niklasf I did not take into account any of the variants. Looking at the code around Assuming we figure out the specialization/feature-gate stuff for |
To select which variants can use the `Zobrist` trait, solve issues raised in niklasf#45. Exposed so third-party variants can implement it. * `Atomic` cannot use it because `play_unchecked` does not handle explosions. * `CrazyHouse` is not properly supported because it does not account for the `Pocket` of the player. * `TreeCheck` is not properly supported because it does not account for the `Check` in the position.
To select which variants can use the `Zobrist` trait, solve issues raised in niklasf#45. Exposed so third-party variants can implement it. * `Atomic` cannot use it because `play_unchecked` does not handle explosions. * `CrazyHouse` is not properly supported because it does not account for the `Pocket` of the player. * `TreeCheck` is not properly supported because it does not account for the `Check` in the position.
Continued in #46. |
for #40