-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yogiraj's soution to dice roller problem #6
Open
yogirajh007
wants to merge
14
commits into
main
Choose a base branch
from
dice-roller
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est so that these functions accept both set and number as argument.
Change drop to my-drop in operations.clj and operations_test.clj
Change "keep" to "drop" in line 91 of markdown file. dlZ will drop lowest z dice, not keep it
models.clj contains the different structures used in the solution.
…21 into dice-roller Dice-engine problem modified. Merging it with local.
Keep and drop functionality works. Different selectors work as well. I have not tested these yet. Reroll logic is not implemented yet.
Change dice-roller to dice-model in some files.
- Add reroll logic. - Move selector switch-case statements to apply-selector function.
add eval functions for bin-op-model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dice roller solution code from yogiraj, to be merged with main