fix hang on Win if server is not alive or died #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Mar 27, 2024
src/redis.nim
Outdated
| @@ -126,7 +126,11 @@ proc managedSend( | |||
| r: Redis | AsyncRedis, data: string | |||
| ): Future[void] {.multisync.} = | |||
| when r is Redis: | |||
| r.socket.send(data) | |||
| when defined(windows): | |||
| if not r.socket.tryRecv(data): | |||
There was a problem hiding this comment.
Why would tryRecv + close be equivalent to send?
There was a problem hiding this comment.
sorry for that, should be trySend(, see the update below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A client on win hang for a long time if the server is not alive. This PR use
trySendon Win to fix this. Also replaceTaintedStringwith string and add small adjustment suggest bynimsuggest.