Network discovery: store the remote address of the peer after finishing a successful handshake #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eligioo
force-pushed
the
stefan/ban-remote-addr-of-peer
branch
from
9288c48
to
b7037e0
Compare
jsdanielh
reviewed
Oct 1, 2024
Eligioo
force-pushed
the
stefan/ban-remote-addr-of-peer
branch
from
b7037e0
to
a9867f5
Compare
…ng a successful handshake. This remote address can later by used for various tasks, like banning. Network connection pool: only look at a part of a Multiaddr to determine if an address is banned.
jsdanielh
force-pushed
the
stefan/ban-remote-addr-of-peer
branch
from
a9867f5
to
c7f80f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Previously we used the
remote_addrdirectly from thehandle_pending_inbound_connectionto check if it's banned. However this will never work correctly because it also containsMultiaddrprotocol parts like/tcp/{random port}and others. Since a new connection always gets opened on a new port you have a differentMultiaddron each connection thus never find a bannedMultiaddr.This PR adds storing a remote address in the
PeerContactMetathat only contains aip4,ip6,dns4ordns6part of aMultiaddrthat can be used to correctly verify if IP or hostname is banned.Lastly this PR solves the problem of banning observed peer addresses, which could lead to banning
127.0.0.1. Fixes #2896.