Add RPC call and config option to rotate keys without restarting #3094
+206
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiaxh
force-pushed
the
fiaxh/voting_keys
branch
2 times, most recently
from
2a85b5e
to
8c20718
Compare
hrxi
reviewed
Nov 18, 2024
Yes, I agree. The implementations will look very similar. Thus, I wanted to first get this reviewed, such that I'm not doing every mistake twice, and then have to fix everything twice 🙂 |
fiaxh
force-pushed
the
fiaxh/voting_keys
branch
3 times, most recently
from
3913104
to
ca59d3e
Compare
fiaxh
force-pushed
the
fiaxh/voting_keys
branch
from
ca59d3e
to
cb2959a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
clippyandrustfmtwarnings.