Changing the max connections per peer so that the seed nodes become public #3095
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I understand the constants correctly, they're about connections between the exactly same peers. Why does the seed node have more than 3 connections to the same peer? Is it because the node got shut down but the connection is still there? They are all on the same node, right? Can a TCP connection to localhost persist in Linux if the process has died? |
jsdanielh
approved these changes
Nov 18, 2024
jsdanielh
force-pushed
the
iicruz/seed-nodes-autonat-fix
branch
from
1f5e526
to
52a4b80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Changes the max connections per peer. The seed nodes have many connections, and this constant is being exceeded. This leads them to get errors when connecting to peers; thus, we mistakenly assume we are not public.
This fixes #3069.
Pull request checklist
clippyandrustfmtwarnings.