FIX: Swap direction of fmap-EPI transform #3106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
#3099 introduced a subtle bug where we applied the inverse transform of what we needed. This is because
init_unwarp_wf
andinit_coeff2epi_wf
have opposite conventions (point and image) for describing transforms.This could be swapped in sdcflows, but I intend to replace
unwarp_wf
with our resampler, so this is just doing the job correctly in the meantime.