Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fetch tags and 200 commits to support describe #3381

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Conversation

effigies
Copy link
Member

This tests the behavior of PRs with the docker build. It should reuse the ghcr.io/nipreps/fmriprep:master cache and create ghcr.io/nipreps/fmriprep:pull-3381 or similar.

It also checks out enough history to properly create a version string.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.06%. Comparing base (03f6cd7) to head (98ad45b).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3381   +/-   ##
=======================================
  Coverage   72.06%   72.06%           
=======================================
  Files          57       57           
  Lines        4231     4231           
  Branches      456      456           
=======================================
  Hits         3049     3049           
  Misses       1067     1067           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member Author

Ah right, I turned off building for PRs. We can disable that switch in PRs we want to publish versions for, or figure out some other condition. We can't use the docker/* approach without modifying the tags ourselves.

@effigies effigies merged commit f0addef into master Oct 12, 2024
19 of 20 checks passed
@effigies effigies deleted the gha-docker-build branch October 12, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant