TYP: Address some recent numpy/mypy type complaints #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1346 +/- ##
=======================================
Coverage 95.34% 95.34%
=======================================
Files 207 207
Lines 29507 29507
Branches 4982 4982
=======================================
Hits 28134 28134
Misses 932 932
Partials 441 441 ☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
fix/minmax-types
branch
from
5e028f3 to
ed26ad9
Compare
effigies
force-pushed
the
fix/minmax-types
branch
from
4b86e83 to
e2fe190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first issue is related to python/typeshed#12562.
The
__rmatmul__/__matmul__issue needs more consideration, but with the attention I can give this at the moment, I'm more worried about introducing subtle breakages or API commitments we might regret in the future, so ignoring the type error is the conservative choice.