Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow bringing the SA from outside the chart @Shaked #263

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/kyverno-notation-aws/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ spec:
- name: POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
fieldPath: metadata.namespace
- name: SERVICE_NAME
value: {{ template "kyverno-notation-aws.serviceName" . }}
- name: DEPLOYMENT_NAME
Expand All @@ -71,7 +71,7 @@ spec:
fieldRef:
fieldPath: metadata.name
- name: AWS_REGION
value: us-west-2
value: {{ .Values.region }}
- name: DEFAULT_TRUST_POLICY
value: aws-signer-trust-policy
volumeMounts:
Expand Down
2 changes: 2 additions & 0 deletions charts/kyverno-notation-aws/templates/serviceaccount.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.serviceAccount.enabled }}
apiVersion: v1
kind: ServiceAccount
metadata:
Expand All @@ -7,3 +8,4 @@ metadata:
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
{{- end -}}
10 changes: 6 additions & 4 deletions charts/kyverno-notation-aws/values.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
region: us-west-2

# -- (string) Override the name of the chart
nameOverride: ~

Expand Down Expand Up @@ -39,16 +41,16 @@ deployment:
# registry: bar.example.com
# username: barbaz
# password: secret2

# -- Allow insecure registry specifies whether to allow insecure connections to registries. Not recommended.
allowInsecureRegistry: false

# -- Max signature attempts specifies the maximum number of signature envelopes that will be processed for verification
maxSignatureAttempts: 30

# Service account configuration
serviceAccount:

enabled: true
# -- The ServiceAccount name
name:

Expand All @@ -59,7 +61,7 @@ serviceAccount:

# Config map configuration
configMap:

# -- The notation-plugin-config configmap name
name: notation-plugin-config

Expand Down