Fix ROUNDDOWN function

nissl-lab · Apr 5, 2024 · 1ae954a · 1ae954a
1 parent 649c565
commit 1ae954a
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/main/SS/Formula/Functions/MathX.cs b/main/SS/Formula/Functions/MathX.cs
@@ -169,8 +169,8 @@ public static double RoundDown(double n, int p)
             {
                 if (p != 0)
                 {
-                    double temp = Math.Pow(10, p);
-                    retval = Sign(n) * Math.Round((Math.Abs(n) * temp) - 0.5, MidpointRounding.AwayFromZero) / temp;
+                    decimal temp = Convert.ToDecimal(Math.Pow(10, p));
+                    retval = Convert.ToDouble(Math.Floor(((decimal)n) * temp) / temp);
                 }
                 else
                 {

diff --git a/testcases/ooxml/XSSF/UserModel/TestXSSFFormulaEvaluation.cs b/testcases/ooxml/XSSF/UserModel/TestXSSFFormulaEvaluation.cs
@@ -755,6 +755,19 @@ public void EvaluateInCellReturnsSameDataType()
             Assert.AreSame(cell, same);
             wb.Close();
         }
+
+        [Test]
+        public void TestRoundDown()
+        {
+            IWorkbook wb = XSSFTestDataSamples.OpenSampleWorkbook("Rounddown_Issue.xlsx");
+            var sheet = wb.GetSheetAt(0);
+            var formula = new XSSFFormulaEvaluator(wb);
+            formula.EvaluateAll();
+            var cellReference = new CellReference("Q13");
+            var row = sheet.GetRow(cellReference.Row);
+            var cell = row.GetCell(cellReference.Col);
+            Assert.AreEqual(17.56, cell.NumericCellValue, 0.00000001);
+        }
     }
 
 }
diff --git a/testcases/test-data/spreadsheet/Rounddown_Issue.xlsx b/testcases/test-data/spreadsheet/Rounddown_Issue.xlsx