Fix removing hyperlinks #1128
Merged
Fix removing hyperlinks #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR closes nissl-lab#690 Unfortunately, I was unable to create a test (help is welcome)
|
LGTM |
|
Hi! It seems that when an empty node of With removal of the condition for hyperlinks count to be more than 0 when writing to stream by this change, the XSSF workbooks with sheets that have no hyperlinks are now coming out "broken" as far as Excel is concerned. 
@Bykiev Could you maybe look into this? Maybe there's a way to do this without removing that guard? |
|
@artem-iron, thanks, I'll check later what can be wrong |
|
Created a PR with potential fix for this: #1171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #690