Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding unit tests: TestRemoveSheetMethod and TestRemoveSheetAtMethod #1147

Closed
wants to merge 1 commit into from
Closed

Adding unit tests: TestRemoveSheetMethod and TestRemoveSheetAtMethod #1147

wants to merge 1 commit into from

Conversation

kenjiuno
Copy link

@kenjiuno kenjiuno commented Aug 2, 2023

#1146

 TestRemoveSheetMethod
   Source: TestXSSFWorkbook.cs line 1200
   Duration: 98 ms

  Message: 
  Expected: 1
  But was:  2


  Stack Trace: 
TestXSSFWorkbook.TestRemoveSheetMethod() line 1219
1)    場所 TestCases.XSSF.UserModel.TestXSSFWorkbook.TestRemoveSheetMethod() 場所 V:\npoi\testcases\ooxml\XSSF\UserModel\TestXSSFWorkbook.cs:行 1219

XSSFWorkbook.RemoveSheetAt method works well already.
XSSFWorkbook.Remove method has issue.

@tonyqus
Copy link
Member

tonyqus commented Aug 11, 2023

Please resolve the conflict first.

@tonyqus tonyqus added this to the NPOI 2.7.0 milestone Aug 11, 2023
@kenjiuno
Copy link
Author

(#1146 has been closed via #1151)

@kenjiuno kenjiuno closed this Aug 12, 2023
@kenjiuno kenjiuno deleted the issue-1146 branch August 12, 2023 14:11
@tonyqus tonyqus removed this from the NPOI 2.7.0 milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjiuno @tonyqus