Some patches and features ported from poi 3.16 #1304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antony-liu
commented
Apr 1, 2024
antony-liu
commented
- Advanced to poi 3.16
- Add event user model.
- Add xslb support
- HPSF improvement
- Xml comments improvement
…-overloading code simpler
…rules per Excel docs
…ument part, even if another type has pinched the next number
…oding an upper-bound
…s#countMatches and Python's str.count(substr)
…cted OldExcel files
…ch from Tim Helmstedt.
…ulaResultType instead of it
…rectoryEntry, List<String> excepts). Use EntryUtils.copyNodes( FilteringDirectoryEntry, FilteringDirectoryEntry ) instead.
* #60519 - Extractor for *SSF embeddings * fix content-type handling in *SSF-EmbeddedExtractor * use last file extension if multiple extensions; close opened stream; extract String constants * EmbeddedExtractor (for *SSF) - added OOXML support * Fix AIOOBE while extracting hssf pictures which are externally linked
#60519 - Extractor for *SSF embeddings
…lient-/ChildAnchor
Convert java style commet to c# style document comment
* 60826 -- add initial support for streaming reading of xlsb files. * bug 61021 - extract abspath from xlsb * bug 61051 -- add new worksheet-like relations for xlsb * bug 61053 -- not a fix, but this aligns XSSFBSheetHandler's behavior with streaming and non-streaming extractors for xlsx * Apply patch to add endSheet() to the XSSFEventBasedExcelExtractor, fixes bug 60737, thanks to user zakim for the patch
|
The PR is too huge. Is it possible you can split it to a few PRs? Otherwise, it's impossible to review the code. For example, you can put all the commits of Xml comments improvement in one PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.