Reorg and unit tests for endpoints pkg #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed mutex locks from task package. Not needed since each task is handled in isolation. - Changed Cancel() function signature to not returns an AttackResponse - Dispatcher returns AttackResponse objects from IAttackStore instead of creating it each time, from the task. - Added unit tests for 100% coverage in endpoints package. - Broke out ITask interface into Getters and Actions.
golangcibot
reviewed
Feb 19, 2019
added 2 commits
February 18, 2019 20:04
|
Added more unit tests for #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handled in isolation.
creating it each time, from the task.