Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): v0.7.9 #493

Merged
merged 1 commit into from
Sep 18, 2024
Merged

chore(release): v0.7.9 #493

merged 1 commit into from
Sep 18, 2024

Conversation

tatsutakein
Copy link
Member

@tatsutakein tatsutakein commented Sep 18, 2024

Issue

  • close #ISSUE_NUMBER 🦕

概要

v0.7.9 をリリースします。

レビュー観点

レビューレベル

  • Lv0: まったく見ないで Approve する
  • Lv1: ぱっとみて違和感がないかチェックして Approve する
  • Lv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証して Approve する
  • Lv3: 実際に環境で動作確認したうえで Approve する

レビュー優先度

  • すぐに見てもらいたい ( hotfix など ) 🚀
  • 今日中に見てもらいたい 🚗
  • 今日〜明日中で見てもらいたい 🚶
  • 数日以内で見てもらいたい 🐢

参考リンク

スクリーンショット

Before After

Summary by CodeRabbit

  • New Features

    • Application version updated to 0.7.9, indicating potential new features and improvements.
  • Bug Fixes

    • Incremented version codes for both Android and iOS platforms, suggesting enhancements or fixes have been addressed.

Copy link

coderabbitai bot commented Sep 18, 2024

Walkthrough

The pull request includes updates to the versioning of both Android and iOS applications. For Android, the versionCode has been incremented from 20 to 21 and the versionName from "0.7.8" to "0.7.9". Similarly, for iOS, the CURRENT_PROJECT_VERSION has been updated from 17 to 18 and the MARKETING_VERSION from "0.7.8" to "0.7.9". These changes signify a new release of the applications.

Changes

File Path Change Summary
app/android/build.gradle.kts Modified versionCode from 20 to 21, versionName from "0.7.8" to "0.7.9"
app/ios/App/Nito/Nito.xcodeproj/project.pbxproj Updated CURRENT_PROJECT_VERSION from 17 to 18, MARKETING_VERSION from 0.7.8 to 0.7.9

Possibly related PRs

  • chore(release): v0.7.8 #487: The changes in this PR also involve updates to the versioning in both the build.gradle.kts and project.pbxproj files, specifically incrementing the versionCode and versionName for Android and the CURRENT_PROJECT_VERSION and MARKETING_VERSION for iOS, indicating a direct connection to the versioning updates in the main PR.

Suggested labels

@app/ios, @app/android

Suggested reviewers

🐰 In the meadow, hops a little hare,
With version numbers dancing in the air.
From 0.7.8 to 0.7.9,
New features bloom, oh how they shine!
Increment the code, let the updates flow,
A joyful release, let the users know! 🌼


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 428d5dc and 836332a.

Files selected for processing (2)
  • app/android/build.gradle.kts (1 hunks)
  • app/ios/App/Nito/Nito.xcodeproj/project.pbxproj (8 hunks)
Additional comments not posted (5)
app/android/build.gradle.kts (1)

20-21: LGTM! The versioning changes are appropriate for the new release.

Incrementing the versionCode and updating the versionName to "0.7.9" aligns with the PR objective of releasing version 0.7.9 of the application. These changes are necessary for publishing the new version on the Google Play Store and ensuring users receive the latest update.

The incremented versionCode will allow the Google Play Store to identify the new version, while the updated versionName provides a clear identifier for the release.

No other changes to the build configuration are observed, indicating that the focus of this PR is solely on preparing the versioning for the new release.

app/ios/App/Nito/Nito.xcodeproj/project.pbxproj (4)

377-377: LGTM!

Incrementing the CURRENT_PROJECT_VERSION for the new release is the correct approach.


396-396: LGTM!

Updating the MARKETING_VERSION to 0.7.9 for the new release is the correct approach.


412-412: LGTM!

The CURRENT_PROJECT_VERSION and MARKETING_VERSION are correctly updated in the Release configuration, consistent with the Debug configuration.

Also applies to: 431-431


447-447: LGTM!

The CURRENT_PROJECT_VERSION and MARKETING_VERSION are correctly updated in both the Debug and Release configurations for the "Dev" target, consistent with the "Prod" target.

Also applies to: 465-465, 481-481, 499-499


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added @app/ios iOS development @app/android Android development labels Sep 18, 2024
@tatsutakein tatsutakein merged commit 76c989b into main Sep 18, 2024
8 checks passed
@tatsutakein tatsutakein deleted the release/v0.7.9 branch September 18, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@app/android Android development @app/ios iOS development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant