New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Koin 関連の処理をカイゼン #60

Merged

tatsutakein merged 2 commits into main from rt/improve-koin

Nov 24, 2023

Member

tatsutakein commented Nov 24, 2023

Issue

close #ISSUE_NUMBER 🦕

概要

Koin 関連の処理をカイゼンします。

AppModule の定義
koinStateMachine の処理を inline から変更

レビュー観点

特になし

レビューレベル

Lv0: まったく見ないで Approve する
Lv1: ぱっとみて違和感がないかチェックして Approve する
Lv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証して Approve する
Lv3: 実際に環境で動作確認したうえで Approve する

レビュー優先度

すぐに見てもらいたい ( hotfix など ) 🚀
今日中に見てもらいたい 🚗
今日〜明日中で見てもらいたい 🚶
数日以内で見てもらいたい 🐢

参考リンク

スクリーンショット

Before	After

tatsutakein added 2 commits

November 24, 2023 08:57


          🐛 koinStateMachine を 修正

cc3510d


          ♻️ AppModule を追加

24b0ed1

tatsutakein requested a review from a team as a code owner

November 24, 2023 00:15

github-actions bot assigned tatsutakein

github-actions bot added @type/improve @feature/top @core/ui @feature/schedule @feature/auth @feature/settings labels

tatsutakein merged commit 09339ed into main

2 checks passed

tatsutakein deleted the rt/improve-koin branch

November 24, 2023 00:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@core/ui @feature/auth @feature/schedule @feature/settings @feature/top @type/improve