Merge pull request #94 from kreuzerk/feature/angular13deps

chore: 🤖 (deps) upgrade deps to v13
nivekcode · Mar 3, 2022 · 592a215 · 592a215
2 parents ca2a3e6 + d324fc9
commit 592a215
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 33 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -31,9 +31,8 @@
     "@angular/platform-browser": "~13.2.4",
     "@angular/platform-browser-dynamic": "~13.2.4",
     "@angular/router": "~13.2.4",
-    "rxjs": "~6.5.5",
-    "tsickle": "^0.39.1",
-    "tslib": "^2.0.0",
+    "rxjs": "~7.5.0",
+    "tslib": "^2.3.0",
     "zone.js": "~0.11.4"
   },
   "devDependencies": {

diff --git a/projects/ng-sortgrid/package.json b/projects/ng-sortgrid/package.json
@@ -3,8 +3,8 @@
   "version": "0.0.1",
   "license": "MIT",
   "peerDependencies": {
-    "@angular/common": "^12.0.0",
-    "@angular/core": "^12.0.0"
+    "@angular/common": "^13.0.0",
+    "@angular/core": "^13.0.0"
   },
   "repository": {
     "type": "git",

diff --git a/projects/ng-sortgrid/src/lib/ngsg-item.directive.spec.ts b/projects/ng-sortgrid/src/lib/ngsg-item.directive.spec.ts
@@ -29,10 +29,10 @@ describe('NgsgItemDirective', () => {
   } as any;
   const ngsgEventService = new NgsgEventsService();
   const scrollHelperService = {
-    scrollIfNecessary: () => { },
+    scrollIfNecessary: () => {},
   } as any;
   const classService = {
-    addActiveClass: jest.fn()
+    addActiveClass: jest.fn(),
   } as any;
 
   beforeEach(() => {
@@ -48,11 +48,6 @@ describe('NgsgItemDirective', () => {
     );
   });
 
-  it('should not set the draggable attribute on the elment', () => {
-    sut.ngAfterViewInit();
-    expect((elementRef.nativeElement as any).draggable).toBeFalsy();
-  });
-
   it('should not set selectedElements if the event did not occur on the host', () => {
     const event = {
       target: {

diff --git a/projects/ng-sortgrid/src/lib/ngsg-item.directive.ts b/projects/ng-sortgrid/src/lib/ngsg-item.directive.ts
@@ -98,7 +98,7 @@ export class NgsgItemDirective implements OnInit, OnChanges, AfterViewInit, OnDe
   }
 
   ngOnDestroy(): void {
-    this.destroy$.next();
+    this.destroy$.next(true);
     this.destroy$.complete();
   }
 
@@ -146,7 +146,7 @@ export class NgsgItemDirective implements OnInit, OnChanges, AfterViewInit, OnDe
     const currentOrder = this.reflectService.reflectChanges(this.ngSortGridGroup, this.el.nativeElement);
     this.sorted.next({previousOrder, currentOrder});
     this.ngsgStore.resetSelectedItems(this.ngSortGridGroup);
-    this.ngsgEventService.dropped$.next();
+    this.ngsgEventService.dropped$.next(true);
   }
 
   @HostListener('click')