Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hostName option and fix docker #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add hostName option and fix docker #26

wants to merge 2 commits into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 10, 2023

No description provided.

@Mic92
Copy link
Member Author

Mic92 commented Jun 10, 2023

Tested by booting the initrd image in a qemu vm.

@MagicRB
Copy link
Collaborator

MagicRB commented Jun 26, 2023

This is something I've been meaning to do, but then we should probably deprecate the name attribute of mkSystem completely.

@Mic92
Copy link
Member Author

Mic92 commented Jun 27, 2023

Is name not used for image names?

@MagicRB MagicRB force-pushed the master branch 4 times, most recently from 730d44b to 4aa8aaa Compare October 7, 2023 18:25
@MagicRB
Copy link
Collaborator

MagicRB commented Oct 18, 2023

It is, but then we'd use the hostNamewhich makes sense in my mind 🤷 (I've got response time of a Moon to Earth DSL connection....)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mic92 @MagicRB