-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flake: adjustments for extensibility, usability, & maintenance #133
Merged
cathaysia
merged 17 commits into
nix-community:master
from
spikespaz-contrib:opinionated-nix-flake
Aug 27, 2024
Merged
Flake: adjustments for extensibility, usability, & maintenance #133
cathaysia
merged 17 commits into
nix-community:master
from
spikespaz-contrib:opinionated-nix-flake
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<https://github.com/nix-systems/nix-systems> Allows the entire flake and outputs to be generic over a `systems` list by allowing it to be overridden as an input. Can be a file or a remote URL.
spikespaz
force-pushed
the
opinionated-nix-flake
branch
2 times, most recently
from
August 27, 2024 04:00
a9d611d
to
8efbe7b
Compare
spikespaz
force-pushed
the
opinionated-nix-flake
branch
from
August 27, 2024 04:07
8efbe7b
to
522c9f2
Compare
spikespaz
force-pushed
the
opinionated-nix-flake
branch
from
August 27, 2024 04:08
522c9f2
to
716ee76
Compare
cathaysia
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ self, ... }@inputs: with inputs;
but I find that for this flake, there are a small number of inputs and all of them are used in the top-level. Therefore, I've named them all as proper arguments.nixfmt-classic
as the Flake's formatter. I find it to be the only formatter that minimizes the effects of whitespace and indentation changes on VCS history.flake-utils
. You don't need to add a dependency just to do something likeflake-utils.lib.eachDefaultSystem
, becauselib.genAttrs
andlib.mapAttrs
accomplish the exact same thing, and don't hide information from newcomers.systems
input with a single file.packages.${system}.nix4vscode
aspackages.${system}.default
.nix4vscode
package. This overlay will use the pinned version of Rust fromrust-toolchain.toml
throughrust-overlay
'srust-bin
interface, always.rustc
flags to run with full features (cargo-expand
,doc
,RUST_BACKTRACE
, etc.).strictDeps = true
where appropriate.nixpkgs
import and properly utilized.I recommend the commits are reviewed individually, this way, if you disagree with my some elements of my style we can rebase appropriately. I am expecting that I will either have to debate removal of
flake-utils
or walk it back completely, but I stand by that we should not add an input for a single function, especially when it interferes with the composability afforded bynix-systems
.