-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to hercules ci #87
Conversation
@Mic92 Can I enable hercules for this repo, will it interfere with the current build/release process? |
bors.toml
Outdated
"check kexec-installer-unstable [x86_64-linux]", | ||
"package netboot-nixos-unstable [x86_64-linux]" | ||
] | ||
status = [ ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list will need to include the Hercules CI checks
@@ -0,0 +1,3 @@ | |||
builds: | |||
exclude: | |||
- "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well remove the Garnix app from the repo instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just to save some cycles, I'll drop this and the garnix app can be disabled when we're ready to merge.
dc64274
to
dab1dac
Compare
Sure. |
@zowoq Just so you are aware, there are people/customers relying on these assets to be available: https://github.com/nix-community/nixos-images/releases/tag/nixos-unstable so please make sure they don't get accidentally deleted or if they do they are quickly restored. |
9457781
to
4ecec9f
Compare
It's a bit awkward running the script in an effect so I'll leave that for now. I'll swap out garnix for hercules and keep the release process in the action. |
3edbec1
to
d9c8d9f
Compare
I'll pick this up again in the next couple of weeks. I'll probably rewrite the script as an effect and let hercules create/merge the flake updates to avoid issues with bors, effects have some new features for publishing releases that may be useful as well. I'll create a fork in this org to work on so I can test publishing releases without disrupting this repo. |
I have some WIP fork for this, it requires a couple of features to be added to HCI's github releases effect. |
I was looking at using the same tag (e.g.
|
I think I prefer using tags per release. Reason is that I don't want to delete old releases but stop updating them at some point. Also over time we might add/remove images. |
I agree that seperate releases is the way to go, someone just needs to implement the missing features to the HCI effect. |
@Kranzes Do you want to take this over? |
Sure, I mean I've already done most of the work needed (see my fork). Only thing missing some some changes to HCI. |
No description provided.