Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overrides): avoid infinite recursion between dask, distributed and dask-expr #1797

Merged
merged 4 commits into from
Sep 30, 2024
Merged

fix(overrides): avoid infinite recursion between dask, distributed and dask-expr #1797

merged 4 commits into from
Sep 30, 2024

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Sep 7, 2024

Contribution checklist (recommended but not always applicable/required):

  • There's an automated test for this change
  • Commit messages or code include references to related issues or PRs (including third parties)
  • Commit messages are conventional - examples from the log include "feat: add changelog files to fixup hook", "fix(contourpy): allow wheel usage", and "test: add sqlalchemy2 test"

@Atry Atry marked this pull request as draft September 9, 2024 18:17
cpcloud
cpcloud requested changes Sep 26, 2024
View reviewed changes
tests/feast-wheel/pyproject.toml Outdated Show resolved Hide resolved
cpcloud
cpcloud previously approved these changes Sep 27, 2024
View reviewed changes
@cpcloud cpcloud dismissed their stale review September 27, 2024 10:33

Incorrectly approved a draft PR

cpcloud
cpcloud requested changes Sep 27, 2024
View reviewed changes
tests/feast-wheel/pyproject.toml Outdated Show resolved Hide resolved
@Atry Atry force-pushed the dask branch 3 times, most recently from 1af7187 to b2700b7 Compare September 28, 2024 17:07
@Atry Atry changed the title fix(overrides): avoid infinite recursion between dask and dask-expr fix(overrides): avoid infinite recursion between dask, distributed and dask-expr Sep 28, 2024
@Atry Atry marked this pull request as ready for review September 28, 2024 17:44
@Atry Atry requested a review from cpcloud September 28, 2024 17:44
@cpcloud cpcloud merged commit ef877b8 into nix-community:master Sep 30, 2024
182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Atry @cpcloud