Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use non-deprecated replacement arguments #1802

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Sep 9, 2024

A lot of tests failed when using --replace-fail, which probably means that the replacements only apply to other versions than the ones used in the tests. This can easily happen if there are overrides for two packages with a dependency between them, since they probably won't build the exact same versions.

Contribution checklist (recommended but not always applicable/required):

  • There's an automated test for this change
  • Commit messages or code include references to related issues or PRs (including third parties)
  • Commit messages are conventional - examples from the log include "feat: add changelog files to fixup hook", "fix(contourpy): allow wheel usage", and "test: add sqlalchemy2 test"

@l0b0 l0b0 changed the title test: Use non-deprecated replacement arguments fix: Use non-deprecated replacement arguments Sep 9, 2024
@adisbladis adisbladis merged commit 0f0943b into nix-community:master Sep 14, 2024
179 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants