FreeRTOS giveFromISR() when releasing within a handler #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Otherwise esp-idf commit 13523c95b42c77b4263ef98ce054962bcb338636 will fail when an assert verifies request to release is by owner task.
copercini
reviewed
Jun 4, 2019
| @@ -440,7 +440,7 @@ void BLECharacteristic::handleGATTServerEvent( | |||
| case ESP_GATTS_CONF_EVT: { | |||
| // ESP_LOGD(LOG_TAG, "m_handle = %d, conf->handle = %d", m_handle, param->conf.handle); | |||
| if(param->conf.conn_id == getService()->getServer()->getConnId()) // && param->conf.handle == m_handle) // bug in esp-idf and not implemented in arduino yet | |||
| m_semaphoreConfEvt.give(param->conf.status); | |||
| m_semaphoreConfEvt.giveFromISR(); | |||
There was a problem hiding this comment.
Shouldn't this be m_semaphoreConfEvt.giveFromISR(param->conf.status); ?
There was a problem hiding this comment.
If you check FreeRTOS.cpp:138, the .give() variant that passes a value stores the value in m_value, which is returned by the .wait() call. Nothing is currently done with this value, so passing & storing it is irrelevant.
Also, there is currently no '.giveFromISR()' variant that passes a value (see FreeRTOS.cpp:147).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a recent commit (#13523c95b42c77b4263ef98ce054962bcb338636) to esp-idf, when releasing a semaphore from within a handler, it is required to use giveFromISR() instead of give(), or an assert (freertos/queue.c:729) that verifies the release request is from the current owner will fail. I have made this change to all locations within cpp_utils where semaphore.give() was invoked from within a callback or handler, since freertos semaphore handling is generic.
I have not verified this works on pre-commit versions of esp-idf.