Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding fix for newest version of esp-idf #948

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

W-M-D
Copy link

@W-M-D W-M-D commented Feb 4, 2020

fixed some files for the newest version of esp-idf

@mitchjs
Copy link

mitchjs commented Mar 7, 2020

@W-M-D can i ask you a question...
just in in freeRTOS.cpp file for insance, i get the ringbuffer change...as that is for the new version of ESP-IDF
but there is a change to the FreeRTOS::Semaphore::Semaphore(std::string name) method
changed the semaphore from binary to mutex
just wondering why

@W-M-D
Copy link
Author

W-M-D commented Mar 10, 2020

Darn, I can't remember off the top of my head. I'm pretty sure there was a change in freertos that requires this.

@trailhead
Copy link

trailhead commented May 4, 2020

I got cpp_utils to compile with this PR, and a couple small tweaks. But BLE scanning seems to be broken and the errors point to the FreeRTOS::Semaphore mentioned above. I'm getting this


0x40093c09: esp_system_abort at /Users/chris/esp/esp-idf/components/esp_system/system_api.c:68

0x4009602e: abort at /Users/chris/esp/esp-idf/components/newlib/abort.c:46

0x40096cd7: xQueueGenericSend at /Users/chris/esp/esp-idf/components/freertos/queue.c:728 (discriminator 5)

0x400d80c2: FreeRTOS::Semaphore::give() at /Users/chris/Documents/clients/wave/simple_ota_example/components/cpp_utils/FreeRTOS.cpp:119

0x400d6825: BLEScan::handleGAPEvent(esp_gap_ble_cb_event_t, esp_ble_gap_cb_param_t*) at /Users/chris/Documents/clients/wave/simple_ota_example/components/cpp_utils/BLEScan.cpp:80 (discriminator 3)

Seems to happen when the scan period is over and Semaphore::give is called. Anyone seen this?

@trailhead
Copy link

FYI, reverting the semaphore changes make the BLE scan work with current IDF. Not sure if it causes any other issues though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants