Igbo Tokenizer Project #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijemmao
reviewed
Oct 21, 2021
| @@ -0,0 +1,14 @@ | |||
| # 🧼 webscraper | |||
There was a problem hiding this comment.
so just to clarify, the tokenizer code will live in this repo under the tokenizer directory?
There was a problem hiding this comment.
or you want just the extracted words?
ijemmao
reviewed
Oct 21, 2021
| # License: MIT | ||
|
|
||
|
|
||
| def cleanhtml(raw_html): |
There was a problem hiding this comment.
Could you write up some documentation on the following:
- What does this script do?
- How to use this script (i.e. what is the format of input that can be handled by this script, how to run the script, etc.)
This new documentation should be another .md file that the public can read through
There was a problem hiding this comment.
this is partly what i wanted us to discuss more on. i was planning of a kind of Github action that can automatically extract words from the curated articles. Due to my limited experience in Github and time, this has not been finalized. Is this something that is useful? or there may be not much need for it?
ijemmao
requested changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have finally kicked off the Igbo tokenizer project to extract words from the articles scraped.
Sorry for the lateness.
Still a number of TO DOs, but this is a kick-off.