Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ Navigation List #740

Merged
merged 7 commits into from
Oct 14, 2024
Merged

Feature/ Navigation List #740

merged 7 commits into from
Oct 14, 2024

Conversation

AdhamAH
Copy link
Member

@AdhamAH AdhamAH commented Oct 7, 2024

@vercel Vercel
Copy link

vercel bot commented Oct 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rijkshuisstijl-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 7:10am
rijkshuisstijl-community-templates ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 7:10am
rvs-rivm-nl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 7:10am

@AdhamAH AdhamAH enabled auto-merge (squash) October 7, 2024 11:16
@MeesD94 MeesD94 self-requested a review October 9, 2024 11:27
@MeesD94
Copy link
Contributor

MeesD94 commented Oct 9, 2024

Ik zie dat op de hover staat een white space op de onderkant van alle navigation list items zit behalve de laatste.
Screenshot 2024-10-09 at 13 41 21

MeesD94
MeesD94 requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@MeesD94 MeesD94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check bovenstaande comment

@AdhamAH AdhamAH requested a review from MeesD94 October 9, 2024 13:40
@Rozerinay
Copy link
Contributor

Rozerinay commented Oct 10, 2024 •
edited
Loading

Design review

Mooi!

Ik zie dat we bij de token todo.navigation-list.item.padding-block de waarde rhc.space.150 hebben meegegeven. In de implementatie is rhc.space.100 gebruikt.

De focus state werkt nog niet optimaal.

image

@AdhamAH
Copy link
Member Author

AdhamAH commented Oct 14, 2024

@Rozerinay @MeesD94

Ik heb de focus fixed. Ook heb ik de juiste token gezetten

@AdhamAH AdhamAH merged commit 549ad64 into main Oct 14, 2024
12 checks passed
@AdhamAH AdhamAH deleted the feature/navigation-list branch October 14, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeesD94 MeesD94 MeesD94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdhamAH @MeesD94 @Rozerinay