Feature/link-list-card (added feedback points) #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Rerbun
changed the title
Rerbun
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback van Robbert
clsxgebruikt zodat je ook nog eigen class names kan toevoegen:<LinkListCard className="large"/>rhc-link-list__cardis niet een logische bem class name.__elementis bedoeld voor een onderdeel van een groter component, terwijl deze component een wrapper is.rhc-link-list-cardis beter. Zie https://getbem.comheading: string;staat geen rich text toe zoals<sub>voor H2O. Je kunt beterReactNodeals type gebruiken.headingText, terwijl de propertyheadingheet.