Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the EDS gem with direct HTTP REST calls via the
BentoSearch::EdsEngine
class.BentoSearch::EdsEngine
only hits the/edsapi/rest
endpoint.To be able to search publications, we need to hit
/edsapi/publication
endpoint. TheBentoSearch::EdsPublicationEngine
extendsBentoSearch::EdsEngine
to hit the publication endpoint. The response data returned is different, soBentoSearch::EdsPublicationEngine
also tries to map useful data from the response.In addition,
BentoSearch::BlacklightEngine
was also refactored to be more in line with the other search engiens provided with thebento_search
gem.httpclient
gem used by the search engines.httpclient
uses very old certs by default, so to use the system certs, the SSL config needs to be reset to use the default SSL paths.See: nahi/httpclient#445