Skip to content

Commit

Permalink
Misc optimizations and typos ros-visualization#2
Browse files Browse the repository at this point in the history
Signed-off-by: Nick Lamprianidis <[email protected]>
  • Loading branch information
nlamprian committed Aug 28, 2023
1 parent 3e6a356 commit 2b758d8
Showing 1 changed file with 6 additions and 13 deletions.
19 changes: 6 additions & 13 deletions src/rqt_reconfigure/node_selector_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,8 @@ def _selection_deselected(self, index_current, rosnode_name_selected):
# Intended to be called from _selection_changed_slot.
self.selectionModel.select(index_current, QItemSelectionModel.Deselect)

try:
param_client_widget = self._nodeitems[
rosnode_name_selected].get_param_client_widget()
except Exception as e:
raise e
param_client_widget = self._nodeitems[
rosnode_name_selected].get_param_client_widget()

# Signal to notify other pane that also contains node widget.
self.sig_node_selected.emit(param_client_widget)
Expand Down Expand Up @@ -225,10 +222,7 @@ def _selection_selected(self, index_current, rosnode_name_selected):
# Only when it's a terminal we move forward.

item_child = self._nodeitems[rosnode_name_selected]
try:
item_widget = item_child.get_param_client_widget()
except Exception as e:
raise e
item_widget = item_child.get_param_client_widget()
logging.debug('item_selected={} child={} widget={}'.format(
index_current, item_child, item_widget))
self.sig_node_selected.emit(item_widget)
Expand All @@ -240,11 +234,10 @@ def _selection_changed_slot(self, selected, deselected):
"""
Send "open ROS Node box" signal.
ONLY IF the selected treenode is the
terminal treenode.
ONLY IF the selected treenode is the terminal treenode.
Receives args from signal QItemSelectionModel.selectionChanged.
:param selected: All indexs where selected (could be multiple)
:param selected: All indices that were selected (could be multiple)
:type selected: QItemSelection
:type deselected: QItemSelection
"""
Expand Down Expand Up @@ -485,7 +478,7 @@ def _refresh_nodes(self):

def set_filter(self, filter_):
"""
Pass fileter instance to the child proxymodel.
Pass filter instance to the child proxymodel.
:type filter_: BaseFilter
"""
Expand Down

0 comments on commit 2b758d8

Please sign in to comment.