Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metadata context not initialized when using resolve plugin #31

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Fix metadata context not initialized when using resolve plugin #31

merged 2 commits into from
Feb 14, 2024

Conversation

maeb
Copy link
Member

@maeb maeb commented Feb 14, 2024

This PR fixes the metadata context not being initialized when resolving through the resolve plugin.

A bug in the shutdown hook of the archivingcache plugin is also fixed.

maeb added 2 commits February 14, 2024 22:17
@maeb
fix: initialize context with metadata
a94902c 
This commit is necessary to get the upstream proxy from the
forward plugin and should have been included as part of commit
d66763a.
@maeb
fix: panic in archivingcache shutdown hook
999495f 
This commit fixes a bug that causes the shutdown hook for the
archivingcache plugin to panic. The bug was introduced in commit
c20f64f
@maeb maeb merged commit 1f6c90d into main Feb 14, 2024
4 checks passed
@maeb maeb deleted the fix/resolve-plugin-missing-upstream-proxy branch February 14, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maeb