Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "N/A" fallback values from contact information #75

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

jampukka
Copy link
Collaborator

Related issue #69

Currently if user omits following properties from configuration:

api.contact.name=
api.contact.email=
api.contact.url=

hakunapi will use N/A as fallback value for each property, which is never valid value for email or url.

Instead just omit the contact information from the OpenAPI description altogether if none of the properties is set and don't set non-null values for fields that are not configured.

Additionally change the finnish_addresses example to reflect the change.

@jampukka jampukka added this to the 1.2.0 milestone Oct 17, 2023
@jampukka jampukka merged commit 12707e4 into main Oct 17, 2023
2 checks passed
@jampukka jampukka deleted the fix/default-openapi-email branch October 17, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant