Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use self.search_layer_ids again #27

Merged
merged 4 commits into from
Nov 2, 2023
Merged

fix: use self.search_layer_ids again #27

merged 4 commits into from
Nov 2, 2023

Conversation

Joonalai
Copy link
Collaborator

@Joonalai Joonalai commented Nov 2, 2023 •
edited
Loading

Description

This PR:

  • Re-enables internal search_layer_ids in set active layer tool
  • Uses real identify in tests instead of mocked one. pytest-qgis==1.3.5 gets rid of fatal exceptions on Windows
  • Adjust ruff autofix behaviour

Type of change

  • Bug fix

  • New feature

  • Other

  • Non-breaking change

  • Breaking change

Developer checklist

  • A CHANGELOG entry has been included (only when change is visible to users)

@Joonalai Joonalai requested a review from rnousia November 2, 2023 07:54
@Joonalai Joonalai self-assigned this Nov 2, 2023
rnousia
rnousia approved these changes Nov 2, 2023
View reviewed changes
test/unit/test_set_active_layer_tool.py Outdated Show resolved Hide resolved
@Joonalai Joonalai merged commit 7f67974 into main Nov 2, 2023
4 checks passed
@Joonalai Joonalai deleted the fix-respect-search-layer-ids branch November 2, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnousia rnousia rnousia approved these changes

Assignees

@Joonalai Joonalai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joonalai @rnousia