CMake: Add option to use system fmt library #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #154 for the idea and the same change will be done with libusb. |
anatol
reviewed
Aug 9, 2024
Biswa96
force-pushed
the
cmake-system-fmt
branch
from
611ffb9
to
950c37e
Compare
fmt library was added in vendor in 21061c1 commit for systems with older fmt versions. Now, distributions can choose to link with their own fmt shared library or use the bundled one.
Biswa96
force-pushed
the
cmake-system-fmt
branch
from
950c37e
to
0e56d13
Compare
|
Thank you! Looks good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmt library was added in vendor in 21061c1 commit for systems with older fmt versions. Now, distributions can choose to link with their own fmt shared library or use the bundled one.