-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NNS topology #108
NNS topology #108
Conversation
0964cfc
to
a0dc8d6
Compare
4881e53
to
c1eba3c
Compare
232a7dc
to
87f6a5f
Compare
6b8fa99
to
38ca5fe
Compare
moreInfoURL?: string; | ||
}; | ||
|
||
export const DetailItemHeader: FC<DetailItemHeaderProps> = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why making such a genric component? cant split for 2 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also copied from kubevirt
Signed-off-by: Aviv Turgeman <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/remove-lgtm |
Reviewed. For me it's great thanks aviv |
Adding a first skeleton to the NNS topology, focusing on:
Enhancements to do/Issues to fix:
Demo:
NNS-topology-1.mp4