Add retry and timeout options for ISH reader #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
about fname assignment, which we don't need to do
causes the 3.6 env to fail
|
Retries shouldn't be needed after moving to AWS (#113), but we might set it up so using AWS would be optional. |
|
As noted here, a historical case with full-length files did succeed, though took > 2 hours. |
bbakernoaa
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also address a few warnings.
Default timeout is 10 (like it was set to before), but now, by default, 4 retries will be made, for a total of 5 tries. And both timeout and retries can be set from
add_data.cc: @jordanschnell
xref: NOAA-CSL/MELODIES-MONET#232