Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the bug of calculating NOx in cmaq.py #179

Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix the bug of calculating NOx in cmaq.py #179

merged 2 commits into from
Jul 30, 2024

Conversation

ytangnoaa
Copy link
Contributor

as NOx=NO+NO2

@zmoon zmoon changed the base branch from stable to develop July 30, 2024 21:50
zmoon
zmoon approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@zmoon zmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ytangnoaa this looks fine to me. Were you able to verify it worked as expected?

@ytangnoaa
Copy link
Contributor Author

Yes, it works as expected. Thank you

@zmoon
Copy link
Member

zmoon commented Jul 30, 2024

I'm going to merge this now even though some flaky tests are currently not passing.

@zmoon zmoon merged commit 33cb622 into noaa-oar-arl:develop Jul 30, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoon zmoon zmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ytangnoaa @zmoon