Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce warnings #183

Merged
merged 13 commits into from
Aug 7, 2024
Merged

Reduce warnings #183

merged 13 commits into from
Aug 7, 2024

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Aug 6, 2024

Address some warnings and reduce noise in CI pytest logs a bit (some warnings raised within the tests for info/debug are not needed in CI).

@zmoon zmoon marked this pull request as ready for review August 6, 2024 22:22
@zmoon
Copy link
Member Author

zmoon commented Aug 6, 2024

I think it may be better to change those messages to use pytest-print instead, not be warnings at all.

@zmoon zmoon marked this pull request as draft August 6, 2024 23:55
@zmoon zmoon marked this pull request as ready for review August 7, 2024 21:32
@zmoon
Copy link
Member Author

zmoon commented Aug 7, 2024

Note that the printer prints don't currently show up when using xdist, regardless of verbosity setting.

@zmoon zmoon merged commit 810c225 into noaa-oar-arl:develop Aug 7, 2024
7 checks passed
@zmoon zmoon deleted the warnings branch August 7, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant