feature/_camx_mm #187
Merged
feature/_camx_mm #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still missing some testing for 3D data
zmoon
reviewed
Aug 27, 2024
Co-authored-by: Zachary Moon <[email protected]>
|
@blychs to me it sounds like setting up a test wouldn't be easy at this time. Maybe we can do it in the future if the data you are using becomes allowed to be public. |
|
Agreed. I think we can move on with this (we can add a warning if you think that's advisable). Hopefully we can get public data sooner rather than later, to allow users to have a test case. |
|
Let's not worry about any warning for this one. |
zmoon
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_camx_mm reader (redone to avoid updating more things that strictly related to this PR).
I still have not built a test. I have checked the output files that are provided by the CAMx developers, but see the following problems to add that as a test case:
a) The files are provided in a tar.gz bundle, which is about 440 MB. As far as I understand, we wanted to have testcases of less than 200 MB. The file we really need is only 32 MB, but we would need to host it somewhere else. I don't know whether that would be acceptable, and I am uncertain about any licensing issues with doing that. If we also want to have the meteorological variables, they are on a separate file, which is only 24 MB for the 2D files, but 300 MB if we require 3D.
b) The files provided by the CAMx are only 2D, and if we need 3D, we would have to get someone to run CAMx. I have not compiled it, and only used output that was provided to me (I don't think that I am allowed to make that public).
c) CAMx output (and input) can be either netCDF or fortran binaries (UAMIV). My code is able to handle both, but we don't have examples with both available.
Let me know your thoughts.
Pablo