hotfix/_camx_mm #191
Merged
hotfix/_camx_mm #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmoon
reviewed
Sep 6, 2024
zmoon
reviewed
Sep 6, 2024
zmoon
reviewed
Sep 6, 2024
zmoon
reviewed
Sep 6, 2024
Co-authored-by: Zachary Moon <[email protected]>
Co-authored-by: Zachary Moon <[email protected]>
zmoon
reviewed
Sep 9, 2024
Co-authored-by: Zachary Moon <[email protected]>
|
I think it's fine to call them what you want for now, and we'll come up with the standardized names and update readers later. |
|
In that case, it is pretty much ready to merge. The advantage of having consistent names accross readers is for the melodies-monet utility. My utility right now reads layer_height_agl, but I can just add temporarily a check to check for different variable names and accommodate for different readers. |
|
Zach, I am sorry, I made a mistake by not noticing that I had changed my
working branch (to include both tempo and camx in the same), and a couple
of bugs that were corrected later slipped here. Should I open a new pull
request?
…On Wed, Sep 11, 2024 at 12:17 PM Zachary Moon ***@***.***> wrote:
Merged #191 <#191> into
develop.
—
Reply to this email directly, view it on GitHub
<#191 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJPVNVNAOWEMUENLQEGNSSDZWCCNNAVCNFSM6AAAAABNZKOTPGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGIZDAOBSHEZTANQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Atmospheric Chemistry Observations & Modeling (ACOM) Lab
NSF National Center for Atmospheric Research (NCAR) - UCAR
P.O. Box 3000, Boulder, CO 80307-3000, USA
Office Nº: FL0 - 2162
Email: ***@***.*** ***@***.***>*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the fixes mentioned in Issue #189 . Hopefully nothing new and unexpected shows up!