Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IAM role for nobl9 agent service account. #12

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

triluch
Copy link
Contributor

@triluch triluch commented Jun 10, 2024

Using account keys is not a good practice and requires creating IAM user account for a service. This is changed to create IAM role and attaching it to Kubernetes ServiceAccount. Agent version bump is required for this to work correctly.

Also adding nobl9 terraform provider version bump.

Andrzej Voss added 2 commits June 10, 2024 15:00
Using account keys is not a good practice and requires creating IAM user
account for a service. This is changed to create IAM role and attaching it
to Kubernetes ServiceAccount.
@triluch triluch requested a review from alexnauda June 10, 2024 13:12
Copy link
Collaborator

@alexnauda alexnauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in both my own account and an AWS workshop account and LGTM

@triluch triluch merged commit 8d5bae8 into main Jun 11, 2024
1 check passed
@triluch triluch deleted the support_iam_roles_for_service_accounts branch June 11, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants