test: setup simapp for testing #6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| name: E2E Test | ||
|
|
||
| on: | ||
| pull_request | ||
|
|
||
| jobs: | ||
| build_image: | ||
| name: Building Heighliner | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Build Docker image | ||
| uses: strangelove-ventures/[email protected] | ||
| with: | ||
| registry: "" # empty registry, image only shared for e2e testing | ||
| tag: local # emulate local environment for consistency in interchaintest cases | ||
| tar-export-path: autocctp_simapp.tar # export a tarball that can be uploaded as an artifact for the e2e jobs | ||
| platform: linux/amd64 # test runner architecture only | ||
| git-ref: ${{ github.head_ref }} # source code ref | ||
|
|
||
| # Heighliner chains.yaml config | ||
| chain: autocctp-simd | ||
| dockerfile: cosmos | ||
| build-target: make build | ||
| build-dir: simapp | ||
| binaries: | | ||
| - simapp/build/simd | ||
|
|
||
| - name: Upload tarball | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: autocctp_simapp.tar | ||
| path: autocctp_simapp.tar | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| .idea | ||
| coverage.out | ||
| /simapp/build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| build: | ||
| @echo "🤖 Building simd..." | ||
| @cd simapp && make build 1> /dev/null | ||
| @echo "✅ Completed build!" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| BRANCH := $(shell git rev-parse --abbrev-ref HEAD) | ||
| COMMIT := $(shell git log -1 --format='%H') | ||
|
|
||
| ifeq (,$(VERSION)) | ||
| VERSION := $(shell git describe --exact-match 2>/dev/null) | ||
| ifeq (,$(VERSION)) | ||
| ifeq ($(shell git status --porcelain),) | ||
| VERSION := $(BRANCH) | ||
| else | ||
| VERSION := $(BRANCH)-dirty | ||
| endif | ||
| endif | ||
| endif | ||
|
|
||
| ldflags := $(LDFLAGS) | ||
| ldflags += -X github.com/cosmos/cosmos-sdk/version.Name=simapp \ | ||
| -X github.com/cosmos/cosmos-sdk/version.AppName=simd \ | ||
| -X github.com/cosmos/cosmos-sdk/version.Version=$(VERSION) \ | ||
| -X github.com/cosmos/cosmos-sdk/version.Commit=$(COMMIT) | ||
| ldflags := $(strip $(ldflags)) | ||
|
|
||
| BUILD_FLAGS := -ldflags '$(ldflags)' | ||
|
|
||
| build: | ||
| @go build -mod=readonly $(BUILD_FLAGS) -o $(PWD)/build/ ./... | ||
|
|
||
| .PHONY: build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| package app | ||
|
|
||
| import ( | ||
| errorsmod "cosmossdk.io/errors" | ||
| "github.com/circlefin/noble-fiattokenfactory/x/fiattokenfactory" | ||
| ftfkeeper "github.com/circlefin/noble-fiattokenfactory/x/fiattokenfactory/keeper" | ||
| "github.com/cosmos/cosmos-sdk/codec" | ||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| sdkerrors "github.com/cosmos/cosmos-sdk/types/errors" | ||
| "github.com/cosmos/cosmos-sdk/x/auth/ante" | ||
| ibcante "github.com/cosmos/ibc-go/v8/modules/core/ante" | ||
| ibckeeper "github.com/cosmos/ibc-go/v8/modules/core/keeper" | ||
| ) | ||
|
|
||
| // HandlerOptions extends the options required by the default Cosmos SDK | ||
| // AnteHandler for our custom ante decorators. | ||
| type HandlerOptions struct { | ||
| ante.HandlerOptions | ||
| cdc codec.Codec | ||
| FTFKeeper *ftfkeeper.Keeper | ||
| IBCKeeper *ibckeeper.Keeper | ||
|
Comment on lines
+19
to
+21
There was a problem hiding this comment. Add validation for The Add a validation check for + if options.cdc == nil {
+ return nil, errorsmod.Wrap(sdkerrors.ErrLogic, "codec is required for ante builder")
+ }Place this validation after the existing checks for other required fields.
|
||
| } | ||
|
|
||
| // NewAnteHandler extends the default Cosmos SDK AnteHandler with custom ante decorators. | ||
| func NewAnteHandler(options HandlerOptions) (sdk.AnteHandler, error) { | ||
| if options.AccountKeeper == nil { | ||
| return nil, errorsmod.Wrap(sdkerrors.ErrLogic, "account keeper is required for ante builder") | ||
| } | ||
|
|
||
| if options.BankKeeper == nil { | ||
| return nil, errorsmod.Wrap(sdkerrors.ErrLogic, "bank keeper is required for ante builder") | ||
| } | ||
|
|
||
| if options.FTFKeeper == nil { | ||
| return nil, errorsmod.Wrap(sdkerrors.ErrLogic, "fiattokenfactory keeper is required for ante builder") | ||
| } | ||
|
|
||
| if options.IBCKeeper == nil { | ||
| return nil, errorsmod.Wrap(sdkerrors.ErrLogic, "ibc keeper is required for ante builder") | ||
| } | ||
|
|
||
| if options.SignModeHandler == nil { | ||
| return nil, errorsmod.Wrap(sdkerrors.ErrLogic, "sign mode handler is required for ante builder") | ||
| } | ||
|
|
||
| anteDecorators := []sdk.AnteDecorator{ | ||
| ante.NewSetUpContextDecorator(), // outermost AnteDecorator. SetUpContext must be called first | ||
| ante.NewExtensionOptionsDecorator(options.ExtensionOptionChecker), | ||
| ante.NewValidateBasicDecorator(), | ||
| ante.NewTxTimeoutHeightDecorator(), | ||
| ante.NewValidateMemoDecorator(options.AccountKeeper), | ||
|
|
||
| fiattokenfactory.NewIsPausedDecorator(options.cdc, options.FTFKeeper), | ||
| fiattokenfactory.NewIsBlacklistedDecorator(options.FTFKeeper), | ||
|
|
||
| ante.NewConsumeGasForTxSizeDecorator(options.AccountKeeper), | ||
| ante.NewDeductFeeDecorator(options.AccountKeeper, options.BankKeeper, options.FeegrantKeeper, options.TxFeeChecker), | ||
| ante.NewSetPubKeyDecorator(options.AccountKeeper), // SetPubKeyDecorator must be called before all signature verification decorators | ||
| ante.NewValidateSigCountDecorator(options.AccountKeeper), | ||
| ante.NewSigGasConsumeDecorator(options.AccountKeeper, options.SigGasConsumer), | ||
| ante.NewSigVerificationDecorator(options.AccountKeeper, options.SignModeHandler), | ||
| ante.NewIncrementSequenceDecorator(options.AccountKeeper), | ||
|
|
||
| ibcante.NewRedundantRelayDecorator(options.IBCKeeper), | ||
| } | ||
|
|
||
| return sdk.ChainAnteDecorators(anteDecorators...), nil | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider preserving build output and adding error handling.
Redirecting stdout to
/dev/nullmight hide important build information or errors. Consider the following improvements:make buildfails.Here's a suggested improvement:
This change will display the build output and stop the process if
make buildfails, providing better visibility and error handling.📝 Committable suggestion