Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test suite #1

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
3685d58
move: blockdb e2e -> examples/cosmos
Reecepbcups Sep 18, 2024
8a55c3c
workflows: migrate e2e to their own jobs
Reecepbcups Sep 18, 2024
c6df5ce
Use only 1 val and 0 nodes for e2e
Reecepbcups Sep 18, 2024
bff04f0
feat: add proper testing.Short() coverage
Reecepbcups Sep 18, 2024
0f260ba
fix: ethermint test
Reecepbcups Sep 18, 2024
0381186
more numNodes 1 val and 0 full
Reecepbcups Sep 18, 2024
64182e1
Merge branch 'main' into reece/simplify-testing
Reecepbcups Sep 18, 2024
78418f6
reduce test flakiness by only verifying with rly
Reecepbcups Sep 20, 2024
087473a
fix: no len check on Validators
Reecepbcups Sep 20, 2024
9df4fee
fix: GreaterOrEqual
Reecepbcups Sep 20, 2024
d04118f
refactor: make `getFullNode` public
Reecepbcups Oct 3, 2024
d62ed3a
review: remove hermes from ICS test (they test elsewhere)
Reecepbcups Oct 3, 2024
33e21c2
Merge branch 'main' into reece/simplify-testing
Reecepbcups Oct 3, 2024
eacbdcc
Merge branch 'main' into reece/simplify-testing
Reecepbcups Oct 8, 2024
dd55a16
fix: lints
Reecepbcups Oct 8, 2024
1c9e702
fix(ci): update to go 1.22
Reecepbcups Oct 8, 2024
3655b86
fix(lint): code website down
Reecepbcups Oct 8, 2024
ba822f6
fix: GetFullNode just to call GetNode() due to NPEs
Reecepbcups Oct 8, 2024
5ccd454
chore: update test binaries
boojamya Oct 17, 2024
aa44ddb
fix: unit test
boojamya Oct 17, 2024
5167643
fix: unit test
boojamya Oct 17, 2024
6bcfcaa
Merge remote-tracking branch 'upstream/reece/simplify-testing' into u…
boojamya Oct 17, 2024
4b1b5e8
chore: replace gaia with chain
boojamya Oct 17, 2024
797e60d
typo: `SimdVersion`
Reecepbcups Oct 18, 2024
eb741ec
fix: broken url
Reecepbcups Oct 18, 2024
86798af
Merge branch 'main' into update-test-suite
Reecepbcups Oct 18, 2024
3c68f10
fix: broadcaster timeout
Reecepbcups Oct 18, 2024
266c3e8
reduce to just 1 validator for internal ict
Reecepbcups Oct 18, 2024
f210b04
fix: rename to `Cosmos End-To-End`
Reecepbcups Oct 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/e2e-conformance.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: Conformance End-To-End Tests

on:
pull_request:

# Ensures that only a single workflow per PR will run at a time. Cancels in-progress jobs if new commit is pushed.
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
test-conformance:
name: test-conformance
runs-on: ubuntu-latest
steps:
# Install and setup go
- name: Set up Go 1.22
uses: actions/setup-go@v5
with:
go-version: '1.22'

- name: checkout interchaintest
uses: actions/checkout@v4

# cleanup environment on self-hosted test runner
- name: clean
run: |-
rm -rf ~/.interchaintest

# run tests
- name: run conformance tests
run: (go test -race -timeout 30m -failfast -v -p 2 ./cmd/interchaintest) || (echo "\n\n*****CHAIN and RELAYER LOGS*****" && cat "$HOME/.interchaintest/logs/interchaintest.log" && exit 1)
33 changes: 33 additions & 0 deletions .github/workflows/e2e-cosmos.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Cosmos End-To-End Tests

on:
pull_request:

# Ensures that only a single workflow per PR will run at a time. Cancels in-progress jobs if new commit is pushed.
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
test-cosmos-examples:
name: test-cosmos-examples
runs-on: ubuntu-latest
steps:
# Install and setup go
- name: Set up Go 1.22
uses: actions/setup-go@v5
with:
go-version: '1.22'
cache: false

- name: checkout interchaintest
uses: actions/checkout@v4

# cleanup environment on self-hosted test runner
- name: clean
run: |-
rm -rf ~/.interchaintest

# run tests
- name: run example cosmos tests
run: go test -race -failfast -timeout 30m -v -p 2 ./examples/cosmos
33 changes: 33 additions & 0 deletions .github/workflows/e2e-ibc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: IBC End-To-End Tests

on:
pull_request:

# Ensures that only a single workflow per PR will run at a time. Cancels in-progress jobs if new commit is pushed.
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
test-ibc-examples:
name: test-ibc-examples
runs-on: ubuntu-latest
steps:
# Install and setup go
- name: Set up Go 1.22
uses: actions/setup-go@v5
with:
go-version: '1.22'
cache: false

- name: checkout interchaintest
uses: actions/checkout@v4

# cleanup environment on self-hosted test runner
- name: clean
run: |-
rm -rf ~/.interchaintest

# run tests
- name: run example ibc tests
run: go test -race -timeout 30m -failfast -v -p 2 ./examples/ibc
76 changes: 0 additions & 76 deletions .github/workflows/e2e-tests.yml

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
types: [created]

env:
GO_VERSION: 1.21
GO_VERSION: 1.22

jobs:
release-static-binary:
Expand All @@ -31,4 +31,4 @@ jobs:
with:
token: ${{ github.token }}
files: |
local-ic
local-ic
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Before you start contributing, make sure you have the following prerequisites in

- [Go](https://golang.org/dl/)
- [Docker](https://www.docker.com/get-started)
- [VSCode (recommended editor)](https://code.visualstudio.com/)
- [VSCode (recommended editor)](https://code.visualstudio.com/) <!-- markdown-link-check-disable-line -->

To get started, follow these steps:

Expand All @@ -76,7 +76,7 @@ To get started, follow these steps:
git checkout -b name/broad-description-of-feature
```

4. Make your changes and commit them with descriptive commit messages.
4. Make your changes and commit them with descriptive commit messages.

5. Test your changes locally with `go test ./...`, or by running the specific test affecting your feature or fix.

Expand All @@ -86,4 +86,4 @@ To get started, follow these steps:
git push origin name/broad-description-of-feature
```

7. Create a pull request (PR) against the main branch of the interchaintest repository. If the PR is still a work-in-progress, please mark the PR as draft.
7. Create a pull request (PR) against the main branch of the interchaintest repository. If the PR is still a work-in-progress, please mark the PR as draft.
4 changes: 2 additions & 2 deletions chain/cosmos/broadcaster.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func (b *Broadcaster) GetFactory(ctx context.Context, user User) (tx.Factory, er
// client.Context.
func (b *Broadcaster) GetClientContext(ctx context.Context, user User) (client.Context, error) {
chain := b.chain
cn := chain.getFullNode()
cn := chain.GetFullNode()

_, ok := b.keyrings[user]
if !ok {
Expand Down Expand Up @@ -160,7 +160,7 @@ func (b *Broadcaster) defaultClientContext(fromUser User, sdkAdd sdk.AccAddress)
// initialize a clean buffer each time
b.buf.Reset()
kr := b.keyrings[fromUser]
cn := b.chain.getFullNode()
cn := b.chain.GetFullNode()
return cn.CliContext().
WithOutput(b.buf).
WithFrom(fromUser.FormattedAddress()).
Expand Down
Loading
Loading