Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch userinfo endpoint #807

Merged
merged 8 commits into from
Aug 1, 2024
Merged

Conversation

Regalijan
Copy link
Member

Given it's a www endpoint, there is a not-insignificant chance that Roblox will remove it in the near future (and we're heading towards v5 anyways)

@alanbixby
Copy link
Member

Please make a new method; getAuthenticatedUser then that utilizes the new endpoint.

We can fix this issue without introducing a breaking change per #809

@Regalijan
Copy link
Member Author

Hi yes it is done

@Regalijan Regalijan requested a review from alanbixby June 11, 2024 00:45
Copy link
Member

@Neztore Neztore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn run lint fails (push to topic?)

@Regalijan
Copy link
Member Author

yarn run lint fails (push to topic?)

Yeah this was fixed after the pr was opened

@Neztore
Copy link
Member

Neztore commented Jul 31, 2024

yarn run lint fails (push to topic?)

Yeah this was fixed after the pr was opened

Huh. I just cloned the repo and ran lint. Will have another look

@Neztore Neztore merged commit 9c93841 into noblox:master Aug 1, 2024
1 of 2 checks passed
@Regalijan Regalijan deleted the switch-userinfo-endpoint branch September 15, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants