Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracking] Model and Op Support #119

Closed
16 of 88 tasks
stellaraccident opened this issue Oct 31, 2023 · 10 comments
Closed
16 of 88 tasks

[tracking] Model and Op Support #119

stellaraccident opened this issue Oct 31, 2023 · 10 comments
Assignees
Labels
tracking-issue Tracking Issue
Milestone

Comments

@stellaraccident
Copy link
Contributor

stellaraccident commented Oct 31, 2023

Tracking model burndown for Gen-AI models and variants that we seek to be serving via Turbine.

@stellaraccident stellaraccident added the tracking-issue Tracking Issue label Oct 31, 2023
@stellaraccident stellaraccident added this to the Path to V1 milestone Oct 31, 2023
@stellaraccident stellaraccident changed the title [tracking] Serving SHARK Gen-AI Models [tracking] Model and Op Support Nov 1, 2023
@newling
Copy link

newling commented Nov 1, 2023

@stellaraccident in meeting chat:

If you are actively working on one, please click the "target" hover to the right of any task to create an issue. Then assign yourself. Note the issue in PRs. Discuss prioritization on the tracking issue and details of the op on the op issue.

@newling
Copy link

newling commented Nov 1, 2023

The list of ops in the issue description is the same as the one @saienduri gathered (in increasing order of appearance, i.e. later ops more important) from parity-bench (I think using https://github.com/nod-ai/SHARK-Turbine/blob/main/tests/generated/running_tests.md) and shared with me and Avinash yesterday.

Someone on the call today also mentioned pixel_shuffle as an important op to support.

@newling
Copy link

newling commented Nov 1, 2023

@stellaraccident I'm not sure I've done what you had in mind - I created a new issue by clicking "New issue" (top right of this page, for me at least). I don't seem to have permission to assign myself to it though

@stellaraccident
Copy link
Contributor Author

You should now have an invite to the organization and I think I added you to a team such that you have write access to the repo.

@lisaliu1
Copy link

@stellaraccident I plan to implemente torch.aten.replication_pad2d op, and created the following issue for that. But I cannot link the op to the created issue. Maybe I missed something.
#286

@schnkmwt
Copy link

Opened a issue tracker for the op torch.aten.diag_embed. @stellaraccident Can you help link it from the list above?
#288

@kumardeepakamd
Copy link

kumardeepakamd commented Dec 21, 2023

@stellaraccident , I had taken up torch.aten.acos (#293). But, @schnkmwt pointed out that https://github.com/frederik-h has taken that up as llvm/torch-mlir#2604 . So, maybe link the op to that issue. I can take up a different one: reflection_pad1d. Please link #293 to that.

@schnkmwt
Copy link

@kumardeepakamd I think this op is already being implemented: llvm/torch-mlir#2604

@AmosLewis
Copy link
Contributor

For ALL new contributors, let's use this to track your newly implemented ops. [tracking] TorchToLinalg and ONNX Op Support #215

@AmosLewis AmosLewis self-assigned this Dec 21, 2023
@AmosLewis
Copy link
Contributor

Close this issue temporarily so we focus on #215 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracking-issue Tracking Issue
Projects
None yet
Development

No branches or pull requests

6 participants