Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement torch.aten.acos #2604

Closed
frederik-h opened this issue Dec 4, 2023 · 5 comments
Closed

Implement torch.aten.acos #2604

frederik-h opened this issue Dec 4, 2023 · 5 comments

Comments

@frederik-h
Copy link
Contributor

The op needs to be implemented according to the Model and op support list.

@frederik-h
Copy link
Contributor Author

I would try do this. @vivekkhandelwal1 What needs to be done to implement the operator? Lowering to linalg or is it necessary to implement other lowerings?

@vivekkhandelwal1
Copy link
Collaborator

I would try do this. @vivekkhandelwal1 What needs to be done to implement the operator? Lowering to linalg or is it necessary to implement other lowerings?

In order to lower this op, you have to add the acos op in the math dialect in MLIR. Then, you can lower the torch.aten.acos -> math.acos op.

@vivekkhandelwal1
Copy link
Collaborator

Hi @frederik-h, if you want to work on a more complex op then you can take torch.aten.reflection_pad2d op. It's a fairly complex op.

@frederik-h
Copy link
Contributor Author

I would try do this. @vivekkhandelwal1 What needs to be done to implement the operator? Lowering to linalg or is it necessary to implement other lowerings?

In order to lower this op, you have to add the acos op in the math dialect in MLIR. Then, you can lower the torch.aten.acos -> math.acos op.

@vivekkhandelwal1 Should the ONNX support also be added as in your commit dc9ea08?

@vivekkhandelwal1
Copy link
Collaborator

I would try do this. @vivekkhandelwal1 What needs to be done to implement the operator? Lowering to linalg or is it necessary to implement other lowerings?

In order to lower this op, you have to add the acos op in the math dialect in MLIR. Then, you can lower the torch.aten.acos -> math.acos op.

@vivekkhandelwal1 Should the ONNX support also be added as in your commit dc9ea08?

Yes

stellaraccident pushed a commit to llvm/llvm-project that referenced this issue Dec 8, 2023
Required for torch-mlir.
Cf. llvm/torch-mlir#2604 "Implement torch.aten.acos".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants