Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start adding the library of custom ops. #296

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Start adding the library of custom ops. #296

merged 6 commits into from
Feb 2, 2024

Conversation

stellaraccident
Copy link
Contributor

Defines a couple of IREE builtins:

  • ops.iree.trace_tensor
  • ops.iree.trace_tensors

Extends the infra for better support:

  • Adds support for Tensor[] arguments to custom ops.

@stellaraccident stellaraccident marked this pull request as draft December 22, 2023 01:46
Defines a couple of IREE builtins:

* `ops.iree.trace_tensor`
* `ops.iree.trace_tensors`

Extends the infra for better support:

* Adds support for `Tensor[]` arguments to custom ops.
@stellaraccident stellaraccident marked this pull request as ready for review February 1, 2024 01:38
python/shark_turbine/ops/__init__.py Show resolved Hide resolved
python/shark_turbine/ops/iree.py Show resolved Hide resolved
python/shark_turbine/ops/iree.py Show resolved Hide resolved
python/shark_turbine/ops/iree.py Show resolved Hide resolved
python/shark_turbine/runtime/op_reg/base.py Show resolved Hide resolved
python/shark_turbine/runtime/op_reg/base.py Show resolved Hide resolved
python/shark_turbine/runtime/op_reg/eager.py Show resolved Hide resolved
Copy link
Contributor

@Groverkss Groverkss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the approach makes sense to me. The user interface seems good and the expand pass approach also seems sensible.

@stellaraccident stellaraccident merged commit a176f99 into main Feb 2, 2024
3 of 4 checks passed
@stellaraccident stellaraccident deleted the iree_ops branch February 2, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants