Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tk] Switch symbolic/shape placeholders to sympy #375

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Conversation

stellaraccident
Copy link
Contributor

By using sympy instead of the stand-in symbolic support, we get full support for index (partial) evaluation, dynamic dimensions and validation checks.

@stellaraccident stellaraccident marked this pull request as ready for review January 31, 2024 01:11
@stellaraccident
Copy link
Contributor Author

@Groverkss This is passing the tests post my refactor to:

  • rebase on sympy
  • carry side-car index data along with the graph (so that we can do more analysis/checking at emission)

I dropped the SliceAnalysis thing and inlined it into some more direct cast utilities.

I'm going to keep iterating on this a little bit because now I can add the stuff at the top level to directly make symbols usable in the IR.

Copy link
Contributor

@Groverkss Groverkss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot. I think I have some doubts about carrying the range analysis with the value and about slicing, but I think we can fix them later.

Let's land this and we can iterate on this further.

@stellaraccident
Copy link
Contributor Author

Thanks. I don't like where that was going either. I needed it when I was in the ditch trying to make slice analysis robust... But then I just deleted it and went with something more direct. This revision still needs this for the moment for accessing dynamic grid values, but I don't like that and will scalpel it out.

@stellaraccident stellaraccident merged commit c1dc94c into main Jan 31, 2024
4 checks passed
@stellaraccident stellaraccident deleted the use_sympy branch January 31, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants